-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editing ELF_Ehdr.e_ident #58
base: master
Are you sure you want to change the base?
Conversation
It didn't work with ELFStruct.pack as it was not a number, but a bindata struct
Oh yeah, rubymine warned me that the "redundant begin block" is required before ruby 2.5, as that is apparently ruby version where syntax
was introduced? gemspec lists 2.4 support, so I decided to refactor into begin/rescue/end block - and that is why tests fail |
Just verified and indeed ruby fails with parser error when using do/rescue/end block with ruby 2.4.6 |
Ruby 2.4 reaches EOL in last year, I would say it's time to drop Ruby 2.4 support. So I prefer you to remove 'being' here and I will update gemspec in another PR. |
This fix isn't enough though, I reproduced a bug and with this patch it still needs a workaround. |
ELF_Ehdr.e_ident attribute setters don't get overridden to add changes to elf's patches
It didn't work with ELFStruct.pack as it was not a number, but a bindata struct
Part of #52