Open
Conversation
houndci-bot
reviewed
May 25, 2017
| # It's strongly recommended that you check this file into your version control system. | ||
|
|
||
| ActiveRecord::Schema.define(:version => 20131114172742) do | ||
| ActiveRecord::Schema.define(version: 20170525130552) do |
Collaborator
There was a problem hiding this comment.
Separate every 3 digits in the integer portion of a number with underscores(_).
| # you'll amass, the slower it'll run and the greater likelihood for issues). | ||
| # | ||
| # It's strongly recommended to check this file into your version control system. | ||
| # It's strongly recommended that you check this file into your version control system. |
Collaborator
There was a problem hiding this comment.
Line is too long. [86/80]
| # | ||
| # cities = City.create([{ name: 'Chicago' }, { name: 'Copenhagen' }]) | ||
| # Mayor.create(name: 'Emanuel', city: cities.first) | ||
| # movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }]) |
Collaborator
There was a problem hiding this comment.
Line is too long. [81/80]
| @@ -1,7 +1,7 @@ | |||
| # This file should contain all the record creation needed to seed the database with its default values. | |||
| # The data can then be loaded with the rake db:seed (or created alongside the db with db:setup). | |||
| # The data can then be loaded with the rails db:seed command (or created alongside the database with db:setup). | |||
Collaborator
There was a problem hiding this comment.
Line is too long. [111/80]
| name Random.alphanumeric | ||
| description Random.paragraphs(1) | ||
| api_key '69704d90-4b77-012f-c334-68a86d3dfd02' | ||
| secret '1e5483d9c6ddbe2f26eecf444ec7a976b2836ab17a209a0940f4dfdee1b3bc93' |
Collaborator
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -1,11 +1,12 @@ | |||
| class CreateRestClient < ActiveRecord::Migration | |||
| class CreateRestClient < ActiveRecord::Migration[5.1] | |||
Collaborator
There was a problem hiding this comment.
Missing frozen string literal comment.
| threads_count = ENV.fetch("RAILS_MAX_THREADS") { 5 } | ||
| threads threads_count, threads_count | ||
|
|
||
| # Specifies the `port` that Puma will listen on to receive requests; default is 3000. |
Collaborator
There was a problem hiding this comment.
Line is too long. [85/80]
| @@ -0,0 +1,56 @@ | |||
| # Puma can serve each request in a thread from an internal thread pool. | |||
Collaborator
There was a problem hiding this comment.
Missing frozen string literal comment.
| # Add additional assets to the asset load path. | ||
| # Rails.application.config.assets.paths << Emoji.images_path | ||
| # Add Yarn node_modules folder to the asset load path. | ||
| Rails.application.config.assets.paths << Rails.root.join('node_modules') |
Collaborator
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| # Be sure to restart your server when you modify this file. | ||
|
|
||
| # Version of your assets, change this if you want to expire all your assets. | ||
| Rails.application.config.assets.version = '1.0' |
Collaborator
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to support Rails 5.