-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added msa to swiftgraph for pull request #87
base: master
Are you sure you want to change the base?
Conversation
Now EDIT: I know that 8k lines are a lot of work, but most of it are from test, run on a randomly generated completely connected graph with 2k vertices and about 7k edges and known MSA (about 7k lines), and an efficient complete implementation of LinkedList with O(1) insertion and deletions, given an iterator (about 700 lines). Let me know if I can help you somehow. |
Sorry for bothering you, any update or anything I could do for you to speed-up the review process? |
Sorry for the late reply and thank you for the contribution. This seems like a fairly large amount of code surface (not in absolute terms but in terms of comparison to the existing library) for a fairly specific feature. And since I doubt there is a large amount of demand for it, it would seem like something that would be hard to find people to maintain over time for a medium size project like SwiftGraph. It will ultimately probably fall on me to update and since it's not a widely used algorithm I'm not sure it's something I would have a particular interest in having to maintain. That's not to say it's not a good contribution, but just something that might not be general purpose enough to belong in the library. In short, I'm just hesitant to add something that won't get maintained and seems niche enough that it might belong in your own application-specific fork. |
See #86