Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theming to hide text cursor if no text is put in #2106

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

J0hannes101
Copy link
Contributor

This PR adds a theming option to hide the text cursor when the input is empty, as discussed in #2105.

It works as expected, but we still need to decide on:

  • The naming of the theming option (currently hide-empty-cursor: true)
  • Which widget should be used to place the hide-empty-cursor option in a theme (currently in entry{})

Also need to update the docs.

@DaveDavenport
Copy link
Collaborator

The name of the widget is the right place to place this option on.
Need to think about naming.. it now sounds like hiding an empty cursor, not hiding cursor on empty textbox.
Maybe 'hide-cursor-on-empty'?

@DaveDavenport DaveDavenport merged commit e70e390 into davatorium:next Feb 25, 2025
7 of 8 checks passed
@DaveDavenport
Copy link
Collaborator

Thanks.

@J0hannes101 J0hannes101 deleted the dev branch February 25, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants