Skip to content

http/client: Don't verify IP #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions http/client.lua
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,9 @@ local function negotiate(s, options, timeout)
if version == 2 then
ssl:setOptions(openssl_ctx.OP_NO_TLSv1 + openssl_ctx.OP_NO_TLSv1_1)
end
if options.host and http_tls.has_hostname_validation then
if options.host and http_tls.has_hostname_validation and not ip then
local params = openssl_verify_param.new()
if ip then
params:setIP(options.host)
else
params:setHost(options.host)
end
params:setHost(options.host)
-- Allow user defined params to override
local old = ssl:getParam()
old:inherit(params)
Expand Down