Skip to content

Switch distutils to setuptools#53

Merged
datumbox merged 11 commits into
mainfrom
update-dependencies
Jun 16, 2025
Merged

Switch distutils to setuptools#53
datumbox merged 11 commits into
mainfrom
update-dependencies

Conversation

@datumbox

Copy link
Copy Markdown
Owner

No description provided.

@datumbox datumbox changed the title Update dependencies Switch distutils to setuptools Jun 16, 2025
@datumbox datumbox requested a review from Copilot June 16, 2025 22:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces distutils with setuptools for building CFFI extensions and updates the project’s build configuration.

  • Adds types-setuptools to the development dependencies.
  • Removes the explicit minimum version for setuptools in pyproject.toml.
  • Switches imports and patches from distutils.command.build_ext to setuptools.command.build_ext in build scripts.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Added types-setuptools and relaxed the setuptools version requirement.
nphash/build.py Replaced distutils imports/patches with setuptools equivalents and adjusted calls to get_ext_filename.
nphash/_build_utils/_ffi_builders.py Updated docstring and switched distutils import to setuptools.command.build_ext.
Comments suppressed due to low confidence (2)

nphash/build.py:10

  • [nitpick] The updated build process using setuptools isn't covered by existing tests. Consider adding integration tests to verify the new FFI build pipeline succeeds under different configurations.
import os

pyproject.toml:39

  • [nitpick] Dropping the minimum setuptools version may lead to compatibility issues with older releases. Consider specifying a lower bound (e.g., setuptools>=68.1) to ensure required features are available.
requires = ["setuptools", "wheel"]

Comment thread nphash/build.py
@datumbox datumbox merged commit 1228614 into main Jun 16, 2025
25 checks passed
@datumbox datumbox deleted the update-dependencies branch June 16, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants