Switch distutils to setuptools#53
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces distutils with setuptools for building CFFI extensions and updates the project’s build configuration.
- Adds
types-setuptoolsto the development dependencies. - Removes the explicit minimum version for
setuptoolsinpyproject.toml. - Switches imports and patches from
distutils.command.build_exttosetuptools.command.build_extin build scripts.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Added types-setuptools and relaxed the setuptools version requirement. |
| nphash/build.py | Replaced distutils imports/patches with setuptools equivalents and adjusted calls to get_ext_filename. |
| nphash/_build_utils/_ffi_builders.py | Updated docstring and switched distutils import to setuptools.command.build_ext. |
Comments suppressed due to low confidence (2)
nphash/build.py:10
- [nitpick] The updated build process using setuptools isn't covered by existing tests. Consider adding integration tests to verify the new FFI build pipeline succeeds under different configurations.
import os
pyproject.toml:39
- [nitpick] Dropping the minimum
setuptoolsversion may lead to compatibility issues with older releases. Consider specifying a lower bound (e.g.,setuptools>=68.1) to ensure required features are available.
requires = ["setuptools", "wheel"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.