Skip to content

Parse and store list names for tasks in Kanban Board documents #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

knu
Copy link
Contributor

@knu knu commented Mar 29, 2025

I'm a long-time user of the Kanban plugin and I just happened to come across this wonderful project. In my use case, it would be helpful to be able to use the list names when querying Kanban tasks, so I created this PR.

I could change the name to kanban_list if list sounds too generic and no other task management plugin has a concept of a "list name".

Copy link

changeset-bot bot commented Mar 29, 2025

⚠️ No Changeset found

Latest commit: 412c25d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rufuspollock
Copy link
Member

rufuspollock commented May 19, 2025

@knu lovely to have your contribution 🙏

sorry we missed this when you first submitted. We'll take a look.

@rufuspollock rufuspollock requested a review from Copilot May 19, 2025 18:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the Kanban task parsing functionality by capturing the list names from Kanban board headings and storing them in the task objects. It updates tests, schema definitions, parsing logic, and database utilities to support the new "list" field.

  • Added new property "list" with accompanying tests in process, parseFile, extractTasks, and computedField specifications.
  • Updated the Task schema and database insert mapping to include the "list" field.
  • Modified the extractTasks function to parse Kanban board headings for list names.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tests/process.spec.ts Added "list" property to test task objects
src/tests/parseFile.spec.ts Updated expected task objects with "list" field
src/tests/extractTasks.spec.ts Included "list" checks for both Kanban and non-Kanban cases
src/tests/computedField.spec.ts Added "list" property in computed field tests
src/lib/schema.ts Integrated "list" field in the Task schema and DB table
src/lib/parseFile.ts Refactored extractTasks to accept metadata and include "list"
src/lib/databaseUtils.ts Updated task insertion mapping to store the "list" field
Comments suppressed due to low confidence (1)

src/lib/parseFile.ts:210

  • The local variable 'metadata' shadows the function parameter 'metadata'. Consider renaming it (e.g., to 'taskMetadata') for clarity and maintainability.
const metadata = extractAllTaskMetadata(description);

@rufuspollock
Copy link
Member

@knu good job and nice to have the test. Merging this in.

@rufuspollock rufuspollock merged commit a3b2581 into datopian:main May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants