Skip to content

feat: Disable noUncheckedIndexedAccess since it forces ! anyway #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dvmoritzschoefl
Copy link
Contributor

The problem:

TS cannot (yet) decide if static indexed access is valid or not. Example:

// columns is typed as T[] (without undefined/null)
if (columns.length === 3) {
    columns[0]... -> TS error
}

Also for loops are not inferable

for (let i = 0; i < 3; i++) {
    if (columns[i]) {
        columns[i]... -> TS error
    }
}

@dvmoritzschoefl dvmoritzschoefl added the type: feature New feature or request label Jan 28, 2025
@dvmoritzschoefl dvmoritzschoefl requested a review from a team as a code owner January 28, 2025 08:36
@@ -17,7 +17,7 @@
"allowSyntheticDefaultImports": true,
"preserveWatchOutput": true,
"strict": true,
"noUncheckedIndexedAccess": true,
"noUncheckedIndexedAccess": false,
Copy link
Contributor

@puehringer puehringer Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this and it does effect non arrays as well, i.e. simple objects: https://www.typescriptlang.org/tsconfig/#noUncheckedIndexedAccess

I don't want to disable it for object access, as I think it is crucial there. Any alternative @dvmoritzschoefl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants