Added proper plotly minified typings

datavisyn · Feb 17, 2022 · 21bc23b · 21bc23b
1 parent 3610f9b
commit 21bc23b
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 14 deletions.
diff --git a/dist/vis/Plot.d.ts.map b/dist/vis/Plot.d.ts.map
diff --git a/dist/vis/Plot.js b/dist/vis/Plot.js
diff --git a/dist/vis/Plot.js.map b/dist/vis/Plot.js.map
diff --git a/package.json b/package.json
@@ -118,6 +118,7 @@
     "@types/react": "^16.9.23",
     "@types/react-dom": "^16.9.5",
     "@types/papaparse": "~5.2.4",
+    "@types/plotly.js-dist-min": "^2.3.0",
     "@typescript-eslint/eslint-plugin": "^5.9.0",
     "@typescript-eslint/parser": "^5.9.0",
     "eslint": "^8.7.0",

diff --git a/src/vis/Plot.tsx b/src/vis/Plot.tsx
@@ -8,10 +8,10 @@ if (typeof window.URL.createObjectURL === 'undefined') {
 
 // Use minified bundle: https://github.com/plotly/react-plotly.js#customizing-the-plotlyjs-bundle
 import Plotly from 'plotly.js-dist-min';
-
-// Use your own `Plotly` object
 import createPlotlyComponent from 'react-plotly.js/factory';
-// tslint:disable-next-line:variable-name
+
+// Use the minified version for our own `Plotly` object
 export const PlotlyComponent = createPlotlyComponent(Plotly);
-// Reexport plotly with proper typings, i.e. see tsd.d.ts
+
+// Reexport the minified plotly with proper typings
 export { Plotly };
diff --git a/tsd.d.ts b/tsd.d.ts
@@ -22,8 +22,3 @@ declare module '*.xml' {
   const content: string;
   export default content;
 }
-
-declare module "plotly.js-dist-min" {
-  import * as Plotly from "plotly.js";
-  export default Plotly;
-}