Fixed setValue in useAsync hook

datavisyn · Apr 4, 2022 · 1af07aa · 1af07aa
1 parent e0bc264
commit 1af07aa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/dist/hooks/useAsync.d.ts.map b/dist/hooks/useAsync.d.ts.map
diff --git a/dist/hooks/useAsync.js b/dist/hooks/useAsync.js
diff --git a/dist/hooks/useAsync.js.map b/dist/hooks/useAsync.js.map
diff --git a/src/hooks/useAsync.tsx b/src/hooks/useAsync.tsx
@@ -46,7 +46,8 @@ export const useAsync = <F extends (...args: any[]) => any, E = Error, T = Await
   const execute = React.useCallback(
     (...args: Parameters<typeof asyncFunction>) => {
       setStatus('pending');
-      setValue(null);
+      // Do not unset the value, as we mostly want to retain the last value to avoid flickering, i.e. for "silent" updates.
+      // setValue(null);
       setError(null);
       const currentPromise = Promise.resolve(asyncFunction(...args))
         .then((response: T) => {
@@ -58,6 +59,7 @@ export const useAsync = <F extends (...args: any[]) => any, E = Error, T = Await
         })
         .catch((e: E) => {
           if (currentPromise === latestPromiseRef.current) {
+            setValue(null);
             setError(e);
             setStatus('error');
           }