cqltypes: Serialize None values in collections as NULLs #1173
+64
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using parepared statements, None values in collections were serialized as empty values (values with length == 0). This is unexpected and inconsistent - None values are serialized as NULLs (vlaues with length == -1) in other cases: - Statement arguments, both for simple and prepared statements - Collection elements in simple statement This commit fixes this weird behavior - now None values should be serialized as NULLs in all cases. It also adds an integration test that checks new behavior. Fixes https://datastax-oss.atlassian.net/jira/software/c/projects/PYTHON/issues/PYTHON-1355
Contributor
Author
|
I assume there is no interest in this PR, so closing. |
Collaborator
|
Sorry @Lorak-mmk , this one just slipped through the cracks. I'd be interested in taking a look at this but we're in something of a freeze right now waiting for this driver to be donated to the ASF so I'm trying to hold off on new commits until that's complete. When it is done I'd like to revisit this idea if you're open to it. Thanks! |
Contributor
Author
|
Ok, thanks for the info. Reopening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using parepared statements, None values in collections were serialized as empty values (values with length == 0). This is unexpected and inconsistent - None values are serialized as NULLs (vlaues with length == -1) in other cases:
This PR fixes this weird behavior - now None values should be serialized as NULLs in all cases. It also adds an integration test that checks new behavior.
Fixes https://datastax-oss.atlassian.net/jira/software/c/projects/PYTHON/issues/PYTHON-1355