Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when accessing prefect graphql installed on a local minikube #99

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Fix error when accessing prefect graphql installed on a local minikube #99

merged 3 commits into from
Nov 5, 2021

Conversation

pipatth
Copy link
Contributor

@pipatth pipatth commented Nov 1, 2021

See #92

  • Add a install_locally boolean variable to use when install on a minikube
  • When install locally, prefect GraphQL is https://localhost:4200/graphql

@pipatth pipatth requested a review from bernardolk November 1, 2021 19:34
@pipatth pipatth mentioned this pull request Nov 1, 2021
Open
bernardolk
bernardolk suggested changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@bernardolk bernardolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Pat. I think we are missing updating the minikube tutorial about setting the "install_locally" variable to True, no? After that I think its all good.

@pipatth pipatth requested a review from bernardolk November 3, 2021 19:24
@pipatth pipatth merged commit 51d8da5 into master Nov 5, 2021
@bernardolk bernardolk deleted the pt/fix-minikube-prefect-graphql branch November 8, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardolk bernardolk bernardolk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipatth @bernardolk