-
-
Notifications
You must be signed in to change notification settings - Fork 0
Pyodide Webview Integration #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vscode-datalayer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements Phase 1 of Pyodide integration to enable offline Python execution in VS Code webviews. The integration allows users to run Python code entirely in the browser using WebAssembly, without requiring a server connection or local Python installation.
- Adds Pyodide kernel support to the webview architecture via MutableServiceManager
- Extends message protocol to support kernel type selection (pyodide vs remote)
- Updates documentation commands from "doc" to "docs" for consistency
Reviewed Changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| webview/types/messages.ts | Extends message interfaces to support optional runtime and kernelType fields |
| webview/services/mutableServiceManager.ts | Adds Pyodide service manager creation and kernel type detection methods |
| webview/notebook/NotebookEditor.tsx | Implements Pyodide kernel selection handling in notebook editor |
| webview/lexical/LexicalWebview.tsx | Adds Pyodide kernel support to lexical document editor |
| webview/hooks/useRuntimeManager.ts | Extends runtime manager hook with Pyodide runtime selection |
| src/services/bridges/kernelBridge.ts | Adds method to connect webviews to Pyodide kernel |
| package.json | Renames documentation commands from "doc" to "docs" |
| netlify.toml | Updates build commands to use new "docs" naming |
| dev/docs/PYODIDE.md | Comprehensive documentation for Pyodide integration |
| dev/docs/DEVELOPMENT.md | Updates development guide with Pyodide architecture details |
| README.md | Adds Pyodide feature documentation and updates file paths |
| DOCUMENTATION.md | Updates documentation generation commands |
| CLAUDE.md | Refactors AI assistant context with Pyodide information |
| .github/workflows/docs.yml | Updates CI workflow to use new docs commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b5e22a2 to
24cfe07
Compare
📦 Extension Build Ready!Download the extension (works on all platforms): The artifact contains the 📖 Installation InstructionsMethod 1: VS Code UI
Method 2: Command Linecode --install-extension datalayer-jupyter-vscode.vsixMethod 3: Drag & Drop
|
e790dce to
6e7011f
Compare
Fixes #15