Update code to use draggable nodes in vscode #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes draggable node functionality in VSCode by addressing scroll-related positioning issues and improving the visual appearance of the drag handle.
Key changes:
- Added scroll offset compensation to correctly position draggable block menu and target line when content is scrolled
- Changed event listeners from scroller element to document level to prevent misalignment after scrolling
- Enhanced CSS styling with better hover states and background properties for improved visibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
packages/lexical/style/lexical/DraggableBlockPlugin.css |
Updated opacity values, added background sizing/positioning properties, and improved hover states with rgba colors |
packages/lexical/src/plugins/DraggableBlockPlugin.tsx |
Implemented scroll compensation logic in positioning functions, switched event listeners to document level, added theme class support, and included helper functions to detect scrolling containers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goanpeca
force-pushed
the
fix/draggable-nodes
branch
from
9bd82a0 to
349d1d2
Compare
echarles
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes datalayer/vscode-datalayer#65