Add pre-commit config and "apply" it - no trailing spaces, sorted imports #271
+43
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just removed unnecessary exclude for codespell and added tomli as needed dependency since we define config in pyproject.toml
=== Do not change lines below ===
{
"chain": [],
"cmd": "pre-commit run --all || pre-commit run --all",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
Code Climate has analyzed commit a2b6768 and detected 0 issues on this pull request. View more on Code Climate. |
|
appveyor -- seems overall in a bad shape should be fixed separately. I do not expect breakages but apparently we do not have any unittesting going on without this appveyor thing... heh, will look into fixing here, but in the longer run I think we need to centralize such testing, filed |
* origin/master: Update __version__ to 1.2.6 [skip ci] Update CHANGELOG BF: use setuptools.errors.OptionError instead of now removed import of distutils.DistutilsOptionError BF: docbuild - use python 3.9 (not 3.8) and upgrade setuptools
=== Do not change lines below ===
{
"chain": [
"a2b6768ff80e3a9a4412ef747d87c3a5cc43a017"
],
"cmd": "pre-commit run --all || pre-commit run --all",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
these are minimal changes, reviewed again -- should not break anything, ran tests locally and they are ok -- let's proceed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed duplicate
.codespellrcsince now we specify in pyproject.tomlInspired by seeing all trailing spaces deleted by @mslw in