Skip to content

Conversation

@BenjaminCharmes
Copy link
Contributor

Closes #1429

Consolidates all tooltip/info box implementations to use a single styled component system.

@BenjaminCharmes BenjaminCharmes force-pushed the bc/unify-tooltip branch 2 times, most recently from bc78811 to 2029f7e Compare November 24, 2025 15:18
@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review November 24, 2025 16:19
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.46%. Comparing base (55b0bc5) to head (909adf2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   79.46%   79.46%           
=======================================
  Files          70       70           
  Lines        5055     5055           
=======================================
  Hits         4017     4017           
  Misses       1038     1038           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Nov 24, 2025

datalab    Run #4241

Run Properties:  status check failed Failed #4241  •  git commit f35e7742f5 ℹ️: Merge 58cfb8136f956dc08dd698f3617ec37f819751f9 into cd8306bb584a9a549b82502d4e05...
Project datalab
Branch Review bc/unify-tooltip
Run status status check failed Failed #4241
Run duration 09m 37s
Commit git commit f35e7742f5 ℹ️: Merge 58cfb8136f956dc08dd698f3617ec37f819751f9 into cd8306bb584a9a549b82502d4e05...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 452
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/component/BlockTooltipTest.cy.jsx • 2 failed tests • Component tests (chrome)

View Output

Test Artifacts
BlockTooltip > with icon mode (showIcon=true) > renders the tooltip with correct content on hover Test Replay Screenshots
BlockTooltip > without icon mode (showIcon=false - dropdown) > renders the tooltip with correct content on hover Test Replay Screenshots
Failed  cypress/component/BlockTooltipTest.cy.jsx • 2 failed tests • Component tests (electron)

View Output

Test Artifacts
BlockTooltip > with icon mode (showIcon=true) > renders the tooltip with correct content on hover Test Replay Screenshots
BlockTooltip > without icon mode (showIcon=false - dropdown) > renders the tooltip with correct content on hover Test Replay Screenshots

@BenjaminCharmes BenjaminCharmes force-pushed the bc/unify-tooltip branch 2 times, most recently from 728f17d to e450144 Compare November 25, 2025 09:42
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I don't think the app fonts are being set correctly though, at least for me it looks like this (i.e., small, and non-figtree):

2025-11-28-204717_747x310_scrot

ml-evs
ml-evs previously approved these changes Dec 1, 2025
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks @BenjaminCharmes! I pushed a commit that just tweaks some padding/font sizes ever so slightly, and the label for the block version.

In the future, I think it would be nice to add more structured info to the blocks schema, e.g., documentation links, plugin repo links, but lets leave that for another time.

@ml-evs ml-evs enabled auto-merge (squash) December 1, 2025 23:50
@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface refactoring For issues/PRs that refactor existing code/features visuals For issues/PRs pertaining to visuals/aesthetics of the interface labels Dec 1, 2025
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, my tweak commit broke the tests

@ml-evs ml-evs moved this to Todo in merge stack Dec 2, 2025
@ml-evs ml-evs moved this from Todo to Done in merge stack Dec 2, 2025
@ml-evs ml-evs merged commit 936e6b7 into main Dec 2, 2025
15 checks passed
@ml-evs ml-evs deleted the bc/unify-tooltip branch December 2, 2025 00:22
BenjaminCharmes added a commit that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring For issues/PRs that refactor existing code/features visuals For issues/PRs pertaining to visuals/aesthetics of the interface webapp For issues/PRs pertaining to the web interface

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Unify styling of info boxes

3 participants