-
Notifications
You must be signed in to change notification settings - Fork 25
Unify tooltip styling and add block version display #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc78811 to
2029f7e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 70 70
Lines 5055 5055
=======================================
Hits 4017 4017
Misses 1038 1038 🚀 New features to boost your workflow:
|
728f17d to
e450144
Compare
5784cde to
33eca52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fd40415 to
0ddf0b2
Compare
ml-evs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks @BenjaminCharmes! I pushed a commit that just tweaks some padding/font sizes ever so slightly, and the label for the block version.
In the future, I think it would be nice to add more structured info to the blocks schema, e.g., documentation links, plugin repo links, but lets leave that for another time.
ml-evs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, my tweak commit broke the tests
95fcbac to
909adf2
Compare
Co-authored-by: Matthew Evans <[email protected]>

Closes #1429
Consolidates all tooltip/info box implementations to use a single styled component system.