test: switch LLM API tests to qwen3.7-max#991
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the API model and tokenizer name from 'qwen2.5-72b-instruct' to 'qwen3.6-plus' across multiple test files. However, 'qwen3.6-plus' appears to be an invalid or non-existent model name, which will cause API calls and tokenizer loading to fail during test execution. It is recommended to correct this to a valid model name, such as 'qwen-plus'.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
fengrui-z
left a comment
There was a problem hiding this comment.
Code uses qwen3.7-max everywhere, but PR title says qwen3.6-plus. Fix the title.
sampling_params is misaligned in several dialog_* test files — not matching the other keyword args.
Unrelated changes:
uv.lockswapsbs4→beautifulsoup4— not related to model migration.test_llm_analysis_filter.pyrewrites RFT test data and addsmin_score=0.7— behavioral change beyond a model swap.
PR description says tests weren't run locally. qwen3.7-max may produce different output formats; recommend at least running the affected tests before merge.
|
Thanks for the thorough review! Here are my responses:
|
Updates LLM API-based tests to use
qwen3.7-maxinstead ofqwen2.5-72b-instruct.This avoids failures caused by restricted or unavailable access to the previous model in CI.
Validation: