fix(checkpoint): resolve relative path issue in Ray checkpoint writer#979
Open
cmgzn wants to merge 2 commits into
Open
fix(checkpoint): resolve relative path issue in Ray checkpoint writer#979cmgzn wants to merge 2 commits into
cmgzn wants to merge 2 commits into
Conversation
Ray's write_parquet is executed by Ray workers whose working directory may differ from the main process. When checkpoint_dir or work_dir is a relative path (e.g., './tmp/...'), Ray workers cannot resolve it correctly, resulting in empty checkpoint directories. Fix: convert work_dir and checkpoint_dir to absolute paths during PartitionedRayExecutor initialization.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the RayExecutorPartitioned class to ensure that work_dir and checkpoint_dir are converted to absolute paths. Feedback was provided regarding the unconditional use of os.path.abspath, which can corrupt remote URIs (such as S3 paths) and may lead to a TypeError if the path is null. It is recommended to implement checks to ensure absolute path conversion is only applied to local, non-null paths.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ray's write_parquet is executed by Ray workers whose working directory may differ from the main process. When checkpoint_dir or work_dir is a relative path (e.g., './tmp/...'), Ray workers cannot resolve it correctly, resulting in empty checkpoint directories.
Fix: convert work_dir and checkpoint_dir to absolute paths during PartitionedRayExecutor initialization.