modified commit such that only the selected files are committed rathe…

…r than everything (unless of course, you've opted to commit and haven't selected anything).

python/commit.py

@@ -27,8 +27,10 @@
 	if not os.path.exists(commitfile):raise Exception("Gitty Error: The tmp commitmsg file doesn't exist.")
 	signoff=False
 	if options.misc and len(options.misc)>0: signoff=True
-	if signoff: command="%s %s %s"%(options.git,"commit -s -F",commitfile)
-	else: command="%s %s %s"%(options.git,"commit -F",commitfile)
+	if signoff: command="%s %s %s"%(options.git,"commit -s -F ",commitfile)
+	else: command="%s %s %s"%(options.git,"commit -F ",commitfile)
+
+	if checkfiles(options): command+=" "+make_file_list_for_git(options.files)
 	rcode,stout,sterr=run_command(command)
 	rcode_for_git_exit(rcode,sterr)
 	exit(0)

src/GTCommitMessageController.h

@@ -31,6 +31,7 @@
 	IBOutlet NSButton * signoff;
 	NSString * commitMessageValue;
 	BOOL addBeforeCommit;
+	NSArray * fileSelection;
 }
 
 @property (readonly,nonatomic) NSString * commitMessageValue;
@@ -39,5 +40,6 @@
 - (void) focus;
 - (BOOL) shouldSignoff;
 - (void) updateMessageFieldAttributes;
+- (void) finishTwoStageCommit;
 
 @end

src/GTCommitMessageController.m

@@ -106,17 +106,24 @@ - (void) onok:(id) sender {
 	commitMessageValue = [val copy];
 	if(target) 
 		[target performSelector:action];
-	//[operations runCommitOperation];
-	//[self disposeNibs];
+	fileSelection = [[[gd activeBranchView] selectedFiles] copy];
 	if (addBeforeCommit)
 		[operations runAddFilesOperation];
 	else
 	{
-		[operations runCommitOperation];
-		[self disposeNibs];
+		[self finishTwoStageCommit];
 	}
 }
 
+- (void) finishTwoStageCommit {
+	if ([gd.gitd stagedFilesCount] >= 1)
+		[operations runCommitOperationWithFiles:fileSelection];
+	else
+		NSBeep();
+	self.addBeforeCommit = false;
+	[self disposeNibs];
+}
+
 - (BOOL) shouldSignoff {
 	return [signoff state];
 }
@@ -130,6 +137,8 @@ - (void) loadNibs {
 - (void) disposeNibs {
 	label=nil;
 	messageField=nil;
+	[fileSelection release];
+	fileSelection = nil;
 	GDRelease(commitMessageValue);
 	[super disposeNibs];
 }

src/GTOpCommit.h

@@ -21,4 +21,6 @@
 @interface GTOpCommit : GTBasePythonTaskOperation {
 }
 
+- (id) initWithGD:(GittyDocument *) _gd andFiles:(NSArray *)files;
+
 @end

src/GTOpCommit.m

@@ -18,9 +18,23 @@
 #import "GTOpCommit.h"
 #import "GittyDocument.h"
 
+@interface GTOpCommit(internal)
+- (void) setArgumentsAndFiles:(NSArray *)files;
+@end
+
 @implementation GTOpCommit
 
-- (void) setArguments {
+- (id) initWithGD:(GittyDocument *) _gd andFiles:(NSArray *)files {
+	if(self=[super initWithGD:_gd]) {
+		args=[[NSMutableArray alloc] init];
+		readsSTDERR=true;
+		[self initializeTask];
+		[self setArgumentsAndFiles:files];
+	}
+	return self;
+}
+
+- (void) setArgumentsAndFiles:(NSArray *)files {
 	if([self isCancelled]) return;
 	[self setArgumentsWithPythonScript:[GTPythonScripts commitScript] setArgsOnTask:false];
 	if([self isCancelled]) return;
@@ -31,7 +45,16 @@ - (void) setArguments {
 	[fileHandle writeData:commitMessage];
 	[fileHandle release];
 	if([[gd commit] shouldSignoff]) [args addObject:@"-m1"];
+	if (files && [files count] > 0) {
+		for (int i = 0; i < [files count]; i++) {
+			[args addObject:[@"-f " stringByAppendingString:[files objectAtIndex:i]]];
+		}
+	}
 	[task setArguments:args];
 }
 
+- (void) setArguments {
+	[self setArgumentsAndFiles:nil];
+}
+
 @end

src/GTOperationsController.h

@@ -140,6 +140,7 @@
 - (void) runRefreshStatusOperation;
 - (void) runAddFilesOperation;
 - (void) runCommitOperation;
+- (void) runCommitOperationWithFiles:(NSArray *)files;
 - (void) runRemoveFilesOperation;
 - (void) runDestageOperation;
 - (void) runDiscardChangesOperation;

src/GTOperationsController.m

@@ -225,6 +225,19 @@ - (void) runAddFilesOperation {
 	}];
 }
 
+- (void) runCommitOperationWithFiles:(NSArray *)files {
+	if(allCanceled) return;
+	if(isRunningCommit) return;
+	isRunningCommit=true;
+	[status showSpinner];
+	GTOpCommit * commit = [[[GTOpCommit alloc] initWithGD:gd andFiles:files] autorelease];
+	NSOperationQueue * q = [self createCancelableQueueWithOperation:commit];
+	[commit setCompletionBlock:^{
+		[self releaseAndRemoveQFromCancelables:q];
+		[self onCommitComplete];
+	}];
+}
+
 - (void) runCommitOperation {
 	if(allCanceled) return;
 	if(isRunningCommit) return;

src/GittyDocument.m

@@ -512,19 +512,8 @@ - (void) onRefreshOperationComplete {
 	[mainMenuHelper invalidate];
 	[contextMenus invalidate];
 	//[self adjustMinWindowSize];
-	/*if(commitAfterAdd) {
-		[commit focus];
-		commitAfterAdd=false;
-	}*/
 	if (commit.addBeforeCommit)
-	{
-		if([gitd stagedFilesCount] >= 1)
-			[operations runCommitOperation];
-		else
-			NSBeep();
-		commit.addBeforeCommit = false;
-		[commit disposeNibs];
-	}
+		[commit finishTwoStageCommit];
 	[sourceListView update];
 	// update the history...
 	[historyView invalidate];