-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fixed some UX and React reconciliation errors on Tags page #15098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ani-malgari
commented
Oct 23, 2025
- Updated error toast to render more meaningful message when tag creation fails.
- Updated the NavBarManu and Table components to use keys correctly to avoid React reconciliation errors.
| Before (click image to zoom) | After (click image to zoom) |
|---|---|
![]() |
![]() |
|
✅ Meticulous spotted 0 visual differences across 1013 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 5bed1ea. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 52 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chriscollins3456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff
f16089b to
5bed1ea
Compare

