Skip to content

Conversation

@ani-malgari
Copy link
Contributor

  • Updated error toast to render more meaningful message when tag creation fails.
  • Updated the NavBarManu and Table components to use keys correctly to avoid React reconciliation errors.
Before (click image to zoom) After (click image to zoom)
Screenshot 2025-10-23 at 4 35 42 PM Screenshot 2025-10-23 at 4 36 06 PM

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 23, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 23, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 23, 2025

✅ Meticulous spotted 0 visual differences across 1013 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 5bed1ea. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Bundle Report

Changes will increase total bundle size by 52 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.58MB 52 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 52 bytes 18.95MB 0.0%

Files in assets/index-*.js:

  • ./src/app/tags/CreateNewTagModal/CreateNewTagModal.tsx → Total Size: 3.12kB

  • ./src/alchemy-components/components/Table/Table.tsx → Total Size: 7.69kB

  • ./src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx → Total Size: 1.54kB

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@ani-malgari ani-malgari force-pushed the NOLINEAR/fixes-on-tags-page branch from f16089b to 5bed1ea Compare October 28, 2025 22:47
@ani-malgari ani-malgari merged commit a6222ca into master Oct 28, 2025
39 of 40 checks passed
@ani-malgari ani-malgari deleted the NOLINEAR/fixes-on-tags-page branch October 28, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants