Skip to content

Conversation

@SalimAbdul-snaplogic
Copy link
Contributor

@SalimAbdul-snaplogic SalimAbdul-snaplogic commented Oct 21, 2025

Snaplogic logo is missing in the datasources
image
And doc url SnapLogic source docs url is pointing to non-existing page.
image

In this PR I fix those 2 issues:

  1. Added logo into ingestionV2 logic.
  2. Fix docs url

After the change locally I can see logo:
image
And I can open doc: https://docs.datahub.com/docs/generated/ingestion/sources/snaplogic

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Bundle Report

Changes will increase total bundle size by 51 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.61MB 51 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 51 bytes 18.99MB 0.0%

Files in assets/index-*.js:

  • ./src/app/ingestV2/source/builder/sources.json → Total Size: 33.51kB

  • ./src/app/ingestV2/source/builder/constants.ts → Total Size: 5.92kB

  • ./src/app/ingest/source/builder/constants.ts → Total Size: 6.77kB

  • ./src/app/ingest/source/builder/sources.json → Total Size: 34.35kB

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Oct 27, 2025
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - thank you!

@deepgarg760
Copy link
Collaborator

@SalimAbdul-snaplogic , check merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants