- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.3k
 
fix(snaplogic): Fix SnapLogic logo and docs url. #15067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(snaplogic): Fix SnapLogic logo and docs url. #15067
Conversation
          Bundle ReportChanges will increase total bundle size by 51 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
 Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
 Files in  
  | 
    
          Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - thank you!
| 
           @SalimAbdul-snaplogic , check merge conflicts  | 
    
b0d62f0    to
    d627631      
    Compare
  
    
Snaplogic logo is missing in the datasources


And doc url SnapLogic source docs url is pointing to non-existing page.
In this PR I fix those 2 issues:
After the change locally I can see logo:

And I can open doc: https://docs.datahub.com/docs/generated/ingestion/sources/snaplogic