Skip to content

fix(ui) : Correct privilledge check for invite token related UI features #15063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

fix(ui) : Correct privilledge check for invite token related UI features #15063

wants to merge 15 commits into from
+5 −5

Conversation

@DucNgoQuang
Copy link
Contributor

@DucNgoQuang DucNgoQuang commented Oct 21, 2025 •
edited
Loading

This commit fix the privilledge check for invite token related UI features including the visibility of invite token button as well as educational/ onboarding pages and the visibility of reset user password. All of them will check for the Manage User Credentials now instead of Mange Policies base on this link

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 7 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.61MB 7 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 7 bytes 18.99MB 0.0%

Files in assets/index-*.js:

  • ./src/app/identity/user/UserList.tsx → Total Size: 5.02kB

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Oct 27, 2025
chriscollins3456
chriscollins3456 approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

@deepgarg760 deepgarg760 deepgarg760 approved these changes

Assignees

No one assigned

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DucNgoQuang @chriscollins3456 @deepgarg760