Skip to content

Conversation

@kyungsoo-datahub
Copy link
Contributor

@kyungsoo-datahub kyungsoo-datahub commented Oct 17, 2025

  • Add Streamlit constants and logos to frontend (ingest V1 and V2)
  • Add support for ingesting Streamlit apps as Dashboard entities
  • Streamlit apps are modeled as dashboards with Streamlit subtype
  • Add comprehensive unit and integration tests with golden files
  • Support streamlit_pattern filtering configuration

This enables DataHub to discover and catalog Streamlit applications deployed in Snowflake, providing visibility into interactive data apps.

- Add support for ingesting Snowflake Streamlit apps as Dashboard entities
- Streamlit apps are modeled as dashboards with Streamlit subtype
- Use Dashboard SDK for simplified metadata generation
- Apply snowflake_identifier() for consistent URN casing with datasets
- Build browse paths manually to avoid duplicate platform instance entries
- Add comprehensive unit and integration tests with golden files
- Support streamlit_pattern filtering configuration

This enables DataHub to discover and catalog Streamlit applications
deployed in Snowflake, providing visibility into interactive data apps.
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 17, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 17, 2025
- Register 'streamlit' platform in bootstrap (v4 → v5) with logo
- Add Streamlit constants and logos to frontend (ingest V1 and V2)
- Ingest apps with platform="streamlit", parent containers, and Snowsight URLs
- Support filtering via streamlit_pattern configuration
@codecov
Copy link

codecov bot commented Oct 22, 2025

Bundle Report

Changes will increase total bundle size by 5.5kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.62MB 5.5kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 5.5kB 19.0MB 0.03%

Files in assets/index-*.js:

  • ./src/app/ingestV2/source/builder/constants.ts → Total Size: 5.92kB

  • ./src/images/streamlitlogo.png → Total Size: 5.4kB

  • ./src/app/ingest/source/builder/constants.ts → Total Size: 6.89kB

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 24, 2025
"url_id": "abc123def456_1",
"comment": "Comment for Streamlit App 1"
},
"externalUrl": "https://app.snowflake.com/ap-south-1.aws/abc12345/#/streamlit-apps/TEST_DB.TEST_SCHEMA.STREAMLIT_APP_1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably it's an issue with the test data... how is the externalUrl does not include the url_id ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url_id is the unique id for the streamlit app. Based on the investigation, it's not related to access url to Streamlit page. Thank you for checking.

Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, good job!

I left some minor comments. The only concerning one is about the identity of the streamlit dashboard.

…oard identifiers

Streamlit apps are identified using their url_id field instead of name
to ensure stable and unique dashboard identifiers. Updated documentation
to include required permissions for Streamlit app ingestion.
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Oct 28, 2025
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Oct 28, 2025
This commit reverts data platform version as
it's not breacking change.
@kyungsoo-datahub kyungsoo-datahub enabled auto-merge (squash) October 30, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants