Skip to content

Multicolumn Assertion Display Issue Fix #12958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Multicolumn Assertion Display Issue Fix #12958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b85a1
Fix text value in Assertion Descriptions for assertions including mul…
inancdokurel Mar 24, 2025
e5b0f06
fix syntax error
inancdokurel Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-web-react/src/app/entity/shared/tabs/Dataset/Validations/DatasetAssertionDescription.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ const getAggregationText = (
case DatasetAssertionScope.DatasetRows:
return getRowsAggregationText(aggregation);
case DatasetAssertionScope.DatasetColumn:
return getColumnAggregationText(aggregation, fields?.length === 1 ? fields[0] : undefined);
return getColumnAggregationText(aggregation, fields?.length === 1 ? fields[0] : fields.join(", "));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm i'm not sure this would fix the whole problem here since getColumnAggregationText expects a single column. would you be able to look into how we could support multiple columns in this function or even create a new function for multi-column use cases?

default:
console.error(`Unsupported Dataset Assertion scope ${scope} provided`);
return 'Dataset is';
Expand Down
Loading