Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion/jdbc-connector): Adding a connector for JDBC connections with customizable platform and sqlglot dialect. #12249

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

acrylJonny
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Sorry, something went wrong.

@acrylJonny acrylJonny marked this pull request as draft December 31, 2024 13:54
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 31, 2024
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 41.27807% with 680 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tion/src/datahub/ingestion/source/jdbc/datasets.py 16.56% 267 Missing ⚠️
...atahub/ingestion/source/jdbc/container_entities.py 36.64% 102 Missing ⚠️
...datahub/ingestion/source/jdbc/stored_procedures.py 24.60% 95 Missing ⚠️
...n/src/datahub/ingestion/source/jdbc/maven_utils.py 24.59% 92 Missing ⚠️
...on/src/datahub/ingestion/source/jdbc/connection.py 58.95% 55 Missing ⚠️
.../datahub/ingestion/source/jdbc/dataset_entities.py 73.77% 16 Missing ⚠️
...ion/src/datahub/ingestion/source/jdbc/reporting.py 58.33% 15 Missing ⚠️
...estion/src/datahub/ingestion/source/jdbc/source.py 80.55% 14 Missing ⚠️
...estion/src/datahub/ingestion/source/jdbc/config.py 86.56% 9 Missing ⚠️
...ion/src/datahub/ingestion/source/jdbc/constants.py 77.50% 9 Missing ⚠️
... and 1 more

❌ Your patch check has failed because the patch coverage (41.27%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...ion/src/datahub/ingestion/source/jdbc/sql_utils.py 68.42% <68.42%> (ø)
...estion/src/datahub/ingestion/source/jdbc/config.py 86.56% <86.56%> (ø)
...ion/src/datahub/ingestion/source/jdbc/constants.py 77.50% <77.50%> (ø)
...estion/src/datahub/ingestion/source/jdbc/source.py 80.55% <80.55%> (ø)
...ion/src/datahub/ingestion/source/jdbc/reporting.py 58.33% <58.33%> (ø)
.../datahub/ingestion/source/jdbc/dataset_entities.py 73.77% <73.77%> (ø)
...on/src/datahub/ingestion/source/jdbc/connection.py 58.95% <58.95%> (ø)
...n/src/datahub/ingestion/source/jdbc/maven_utils.py 24.59% <24.59%> (ø)
...datahub/ingestion/source/jdbc/stored_procedures.py 24.60% <24.60%> (ø)
...atahub/ingestion/source/jdbc/container_entities.py 36.64% <36.64%> (ø)
... and 1 more

... and 58 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf1576...ba9b6cd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant