Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tableau): set ingestion stage report and perftimers #12234

Merged

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 27, 2024

Locally tested:

...
{'ingestion_stage_durations': {'Ingesting Tableau Site: 9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c acryldatatableaupartnershipportal at 2025-01-03 09:59:42.763195+00:00': 66.31},
...

 'extract_usage_stats_timer': {'acryldatatableaupartnershipportal': 0.38},
 'fetch_groups_timer': {},
 'populate_database_server_hostname_map_timer': {},
 'populate_projects_registry_timer': {'acryldatatableaupartnershipportal': 1.49},
 'emit_workbooks_timer': {'acryldatatableaupartnershipportal': 12.49},
 'emit_sheets_timer': {'acryldatatableaupartnershipportal': 4.75},
 'emit_dashboards_timer': {'acryldatatableaupartnershipportal': 1.52},
 'emit_embedded_datasources_timer': {'acryldatatableaupartnershipportal': 39.94},
 'emit_published_datasources_timer': {'acryldatatableaupartnershipportal': 9.69},
 'emit_custom_sql_datasources_timer': {'acryldatatableaupartnershipportal': 0.53},
 'emit_upstream_tables_timer': {'acryldatatableaupartnershipportal': 1.81},

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 27, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 2, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 3, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 7, 2025
Copy link

codecov bot commented Jan 9, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1940 1 1939 40
View the top 1 failed tests by shortest run time
tests.integration.kafka.test_kafka_state::test_kafka_ingest_with_stateful
Stack Traces | 125s run time
docker_compose_runner = <function docker_compose_runner.<locals>.run at 0x7f6ff3bfd190>
pytestconfig = <_pytest.config.Config object at 0x7f706ea4ef00>
tmp_path = PosixPath('.../pytest-of-runner/pytest-0/test_kafka_ingest_with_statefu0')
mock_time = None
mock_datahub_graph = <MagicMock spec='DataHubGraph' id='140118778011888'>

    @freeze_time(FROZEN_TIME)
    @pytest.mark.integration
    def test_kafka_ingest_with_stateful(
        docker_compose_runner, pytestconfig, tmp_path, mock_time, mock_datahub_graph
    ):
        test_resources_dir = pytestconfig.rootpath / "tests/integration/kafka"
        topic_prefix: str = "stateful_ingestion_test"
        topic_names: List[str] = [f"{topic_prefix}_t1", f"{topic_prefix}_t2"]
        platform_instance = "test_platform_instance_1"
    
        with docker_compose_runner(
            test_resources_dir / "docker-compose.yml", "kafka"
        ) as docker_services:
>           wait_for_port(docker_services, "test_broker", KAFKA_PORT, timeout=120)

.../integration/kafka/test_kafka_state.py:94: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.../datahub/testing/docker_utils.py:36: in wait_for_port
    docker_services.wait_until_responsive(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = Services(_docker_compose=DockerComposeExecutor(_compose_command='docker compose', _compose_files=[PosixPath('/home/run...adata.../integration/kafka/docker-compose.yml')], _compose_project_name='pytest4962-kafka'), _services={})
check = <function wait_for_port.<locals>.<lambda> at 0x7f6ff3bfdf50>
timeout = 120, pause = 0.5, clock = <built-in function perf_counter>

    def wait_until_responsive(
        self,
        check: Any,
        timeout: float,
        pause: float,
        clock: Any = timeit.default_timer,
    ) -> None:
        """Wait until a service is responsive."""
    
        ref = clock()
        now = ref
        while (now - ref) < timeout:
            if check():
                return
            time.sleep(pause)
            now = clock()
    
>       raise Exception("Timeout reached while waiting on service!")
E       Exception: Timeout reached while waiting on service!

venv/lib/python3.8.../site-packages/pytest_docker/plugin.py:120: Exception

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 9, 2025
@sgomezvillamor sgomezvillamor merged commit 9d9a368 into master Jan 9, 2025
78 checks passed
@sgomezvillamor sgomezvillamor deleted the feature/cus-3546-chore-tableau-ingestion-stage-reporting branch January 9, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants