Multicolumn Assertion Display Issue Fix #12958
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple columns Such an example would be ExpectCompoundColumnsToBeUnique (https://greatexpectations.io/expectations/expect_compound_columns_to_be_unique/)
github-actions
bot
added
product
datahub-cyborg
bot
added
the
needs-review
| @@ -181,7 +181,7 @@ const getAggregationText = ( | |||
| case DatasetAssertionScope.DatasetRows: | |||
| return getRowsAggregationText(aggregation); | |||
| case DatasetAssertionScope.DatasetColumn: | |||
| return getColumnAggregationText(aggregation, fields?.length === 1 ? fields[0] : undefined); | |||
| return getColumnAggregationText(aggregation, fields?.length === 1 ? fields[0] : fields.join(", ")); | |||
There was a problem hiding this comment.
hm i'm not sure this would fix the whole problem here since getColumnAggregationText expects a single column. would you be able to look into how we could support multiple columns in this function or even create a new function for multi-column use cases?
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12957