feat: add sign parameter to upload_data for notary-signed uploads (#44) - #139
Open
miles-on-nightshift wants to merge 1 commit into
Open
Conversation
…tafund#44) Adds optional sign parameter to upload_data tool and gateway client. When sign="notary", the gateway cryptographically signs the data at upload time. Response surfaces notary signer address when present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
signparameter for theupload_datatool, resolving #44.gateway_client.py— adds optionalsign: Optional[str] = Nonetoupload_data(), passes it as a query param when providedserver.py— addssignto the MCP tool schema as an enum["notary"]with descriptive help text; surfaces notary signer address in success response when presentBehaviour
When
sign="notary", the request becomesPOST /api/v1/data/?sign=notary&stamp_id=..., triggering the gateway's notary service to cryptographically sign the data at upload time. The success response includes:When
signis omitted, behaviour is identical to the previous release.Test plan
pytest tests/test_gateway_client.py— 12 passedsign="notary"against a dev gateway with notary enabled and confirm signature fields appearCloses #44
🤖 Generated with Claude Code