Fix gateway integration test pollution from .env.local - #80
Merged
Conversation
The gateway_url fixture was reading PROVENANCE_GATEWAY_URL, which .env.local overrides to localhost:8000 for local development. This caused gateway tests to fail when run with .env.local sourced. Use a separate INTEGRATION_GATEWAY_URL env var so integration tests always default to the production gateway independently of app config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway_urlfixture in integration tests was readingPROVENANCE_GATEWAY_URL, which.env.localoverrides tolocalhost:8000for local development.env.localsourced (needed for x402/chain tests)INTEGRATION_GATEWAY_URLenv var, defaulting to production gateway, keeping integration tests independent of app configTest plan
.env.localsourced