Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1805: failing dry-runs when table/view/assertion do not exist #1893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #1805: failing dry-runs when table/view/assertion do not exist #1893

wants to merge 1 commit into from

Conversation

mkamysz
Copy link

@mkamysz mkamysz commented Jan 21, 2025

Fixes #1805, as former fix in #1806 has been reverted in #1834.

  • Only attempt to set metadata for tables if BigQuery option dryRun is false
  • Assertions consist of two separate queries, first creating a view and second selecting from the view, expecting an empty result set; the second part of this process needs to be skipped for dry runs, as the view does not actually get created

@mkamysz
add handling of issues in dataform-co#1805
3859441 
1. only set metadata when dryRun is false
2. add marker to row count query part of an assertion. check for marker in create query job and don't execute query if dryRun is true
@mkamysz mkamysz requested a review from a team as a code owner January 21, 2025 13:43
@mkamysz mkamysz requested review from zaptot and removed request for a team January 21, 2025 13:43
@mkamysz mkamysz changed the title Fix #1805 Fix #1805: failing dry-runs when table/view/assertion do not exist Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaptot zaptot Awaiting requested review from zaptot zaptot is a code owner automatically assigned from dataform-co/dataform-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dry run fails when table/view/assertion to be created does not exists
1 participant
@mkamysz