Skip to content

Add task to cleanup subject keywords#2804

Merged
ryscher merged 3 commits intomainfrom
4837-recuration-subject-keyword-cleanup
Mar 17, 2026
Merged

Add task to cleanup subject keywords#2804
ryscher merged 3 commits intomainfrom
4837-recuration-subject-keyword-cleanup

Conversation

@alinvetian
Copy link
Contributor

@alinvetian alinvetian requested a review from ahamelers March 9, 2026 15:36
@alinvetian alinvetian requested a review from ryscher March 12, 2026 07:26
Copy link
Collaborator

@ahamelers ahamelers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, though I'd also like @ryscher to test!

@ryscher
Copy link
Member

ryscher commented Mar 13, 2026

When the first SQL statement runs, it replaces offending characters with empty values. This leaves the dataset having a Subject object that has no subject field, and the subjects for the dataset will not render.

@alinvetian
Copy link
Contributor Author

alinvetian commented Mar 17, 2026

@ryscher I entirely removed the first query since it was removing the subject value for 412 subjects that was not supposed to.

Also there are multiple subjects like [ 54 ] Cohort studies that became Cohort studies while having only 2 digits

@ryscher ryscher merged commit 1284574 into main Mar 17, 2026
7 checks passed
@ryscher ryscher deleted the 4837-recuration-subject-keyword-cleanup branch March 17, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recuration – Subject keyword cleanup

3 participants