Add "FRDR" catalog alongside DataCite catalog#48
Open
axfelix wants to merge 74 commits intodatacite:masterfrom
Open
Add "FRDR" catalog alongside DataCite catalog#48axfelix wants to merge 74 commits intodatacite:masterfrom
axfelix wants to merge 74 commits intodatacite:masterfrom
Conversation
Do not transform setSpec URL (keep as homepage_url)
This reverts commit 6a07425.
Author
|
Looks like tests are failing because we haven't set a default for DataCite vs. FRDR in environment variables. Want me to just change it so it defaults to DataCite? |
…nts (rightsList, descriptions) when empty
Collaborator
|
Thanks for the PR, I will try and take a proper look through as soon as I can. |
…appears in oai_dc)
… to category/keywords
…t (these are public)
…y stop when the total_records is exceeded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As promised, this adds support for another "FRDR" catalog to the default DataCite option. I was able to do an automatic merge on a three month old fork from upstream, which is a good sign, I don't think we've broken anything, and I've been fairly consistent with your existing coding conventions and we think we've made most/all of the changes we'll need to make to support our own production use case. Let me know what you think and thanks for considering the PR!