Improve footer accessibility and color contrast using brand colors#24
Improve footer accessibility and color contrast using brand colors#24
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughA new SCSS color palette file is introduced with DataCite brand colors defined as Sass variables. This file is imported into the main stylesheet, and the footer component is updated to use the new primary dark blue color variable instead of a generic dark gray reference. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b14bc05 to
e138dd7
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves footer text/link contrast for accessibility by introducing official DataCite brand color variables and applying them in the footer styles.
Changes:
- Added a new SCSS partial containing DataCite Design Manual v2.1 brand color variables.
- Imported the new brand color partial into the main
doi.scssbuild pipeline. - Updated footer text/link colors to use
$datacite-primary-dark-blueand regenerateddist/CSS outputs.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/stylesheets/doi/components/_footer.scss | Switches footer foreground colors to the new high-contrast brand variable. |
| src/stylesheets/doi.scss | Imports the new datacite_colors partial into the global Sass compilation flow. |
| src/stylesheets/_datacite_colors.scss | Introduces the DataCite brand color palette variables (with !default). |
| dist/stylesheets/doi.min.css | Updated minified build output reflecting the new footer colors. |
| dist/stylesheets/doi.css | Updated compiled CSS reflecting the new footer colors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6a1f084 to
82ae373
Compare
82ae373 to
e7543dd
Compare
Purpose
The primary purpose of this PR is to improve the accessibility of the footer component by updating its color contrast. By implementing the official brand colors from the DataCite Design Manual v2.1, we ensure that text elements meet modern accessibility standards while maintaining brand consistency.
Approach
$dark-grayvariables in the footer component with the high-contrast$datacite-primary-dark-blueto ensure better legibility and WCAG compliance.Key Modifications
src/stylesheets/_datacite_colors.scss: (New) Added official DataCite Design Manual v2.1 color palette, including primary, secondary, and additional brand colors.src/stylesheets/doi.scss: Imported the new branding colors into the main stylesheet workflow.src/stylesheets/doi/components/_footer.scss: Updated.footer, footer links (a), and.color-descriptionto use$datacite-primary-dark-blueinstead of$dark-gray.Important Technical Details
!defaultflag, allowing for easier overrides if needed in specific implementations.$dark-grayto$datacite-primary-dark-blue(#243B54) provides a darker, more distinct foreground against the$lighter-graybackground, improving the contrast ratio for accessibility.Types of changes
Reviewer, please remember our guidelines:
Summary by CodeRabbit
Release Notes