Skip to content

Refactor ROR reference data to use S3-backed dynamic caching #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Refactor ROR reference data to use S3-backed dynamic caching #1486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
054dd94
Initial plan
Copilot Feb 24, 2026
9a92320
Switch ROR mapping files from local resources to S3-backed chunked Ra…
Copilot Feb 24, 2026
fc2c74b
refactor: change RorReferenceStore to individual key-value caching
jrhoads Feb 25, 2026
89f4899
test: refactor Rorable spec to use specific method stubbing and impro…
jrhoads Feb 25, 2026
f9e4434
test: update RorReferenceStore tests to use per-key caching instead o…
jrhoads Feb 25, 2026
0f4fcbd
perf: optimize cache lookup logic and fix cold cache test cases
jrhoads Feb 25, 2026
b2b7b0e
Appease rubocop
jrhoads Feb 25, 2026
f2de6d0
test: add ROR reference store test helpers and shared context
jrhoads Feb 25, 2026
daebf99
test: include ROR funding stubs context in DOI model and request specs
jrhoads Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/models/concerns/rorable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ module Rorable

def get_ror_from_crossref_funder_id(funder_id)
funder_id_suffix = funder_id.split("10.13039/").last
FUNDER_TO_ROR[funder_id_suffix]
RorReferenceStore.funder_to_ror(funder_id_suffix)
end

def get_ror_parents(ror_id)
normalized_ror = "https://#{ror_from_url(ror_id)}"
ROR_HIERARCHY[normalized_ror]&.fetch("ancestors", []) || []
hierarchy = RorReferenceStore.ror_hierarchy(normalized_ror)
hierarchy&.dig("ancestors") || []
end
end
21,950 changes: 0 additions & 21,950 deletions app/resources/funder_to_ror.json
View file
Open in desktop

This file was deleted.

Loading