Skip to content

Get client when processing nameIdentifiers and skip pushes if DOI is in a raidRegistry#229

Merged
codycooperross merged 3 commits intomasterfrom
raid-orcid-skip-fix
Jan 20, 2026
Merged

Get client when processing nameIdentifiers and skip pushes if DOI is in a raidRegistry#229
codycooperross merged 3 commits intomasterfrom
raid-orcid-skip-fix

Conversation

@codycooperross
Copy link
Contributor

@codycooperross codycooperross commented Jan 20, 2026

Purpose

This PR is a fix for #226

The previous PR only skipped NameIdentifier processing when using NameIdentifier.import_one, which is, as far as I now know, an unused method accessed primarily via rake task. This PR targets the Importable.parse_record flow, wherein a DOI gets created or updated in lupo and pushes a SQS message to levriero for processing.

For NameIdentifier.import and NameIdentifier.import_by_month, client data would not be available, and thus NameIdentifier would create event data and ORCID claims even if a DOI were in a raidRegistry. However, these methods are, again, to my knowledge, unused and accessed primarily via rake task.

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

…y is skipped when running NameIdentifier import tasks
…dRegistry is skipped when running NameIdentifier import tasks"

This reverts commit 1b0eb2e.
@codycooperross codycooperross merged commit 3502e77 into master Jan 20, 2026
2 checks passed
@codycooperross codycooperross deleted the raid-orcid-skip-fix branch January 20, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants