Get client when processing nameIdentifiers and skip pushes if DOI is in a raidRegistry#229
Merged
codycooperross merged 3 commits intomasterfrom Jan 20, 2026
Merged
Conversation
…in a raidRegistry
…y is skipped when running NameIdentifier import tasks
…dRegistry is skipped when running NameIdentifier import tasks" This reverts commit 1b0eb2e.
jrhoads
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a fix for #226
The previous PR only skipped NameIdentifier processing when using
NameIdentifier.import_one, which is, as far as I now know, an unused method accessed primarily via rake task. This PR targets theImportable.parse_recordflow, wherein a DOI gets created or updated in lupo and pushes a SQS message to levriero for processing.For
NameIdentifier.importandNameIdentifier.import_by_month, client data would not be available, and thus NameIdentifier would create event data and ORCID claims even if a DOI were in a raidRegistry. However, these methods are, again, to my knowledge, unused and accessed primarily via rake task.closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: