Skip to content

initial project creation#1

Merged
wendelfabianchinsamy merged 40 commits intomainfrom
project-creation
Mar 24, 2025
Merged

initial project creation#1
wendelfabianchinsamy merged 40 commits intomainfrom
project-creation

Conversation

@wendelfabianchinsamy
Copy link
Contributor

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team March 18, 2025 12:06
@wendelfabianchinsamy wendelfabianchinsamy self-assigned this Mar 18, 2025

source "https://rubygems.org"

ruby "3.1.6"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're making a new app, can we not go newer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wanted to initially keep this in line with the lupo.

rack (>= 1.3)
rackup (2.2.1)
rack (>= 3)
rails (7.1.5.1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not rails 8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we wanted to initially keep this in line with the lupo and not introduce too many points of failure.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these just created by default? the channel stuff is for websockets I think, but maybe its just default as of rails 7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes those are defaults when you run rails new to create an app.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above, this is default? we dont use mailers from here.

Copy link

@richardhallett richardhallett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider the versions of rails and such going forward, but to get going this is acceptable start.

@wendelfabianchinsamy wendelfabianchinsamy merged commit 7206600 into main Mar 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants