Skip to content

Automatically deploy to vercel preview in the 'test pull request' git… #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svogt0511 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Automatically deploy to vercel preview in the 'test pull request' git… #956

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2597bee
Automatically deploy to vercel preview in the 'test pull request' git…
svogt0511 Mar 20, 2026
208fa38
Enhance deploy job in pull request workflow with permissions and cond…
jrhoads Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,31 @@
needs: call_build
uses: ./.github/workflows/cypress_test.yml
secrets: inherit

deploy:
needs: [call_build, ember_test, cypress_test]
runs-on: ubuntu-latest
environment: vercel-bracco-preview
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
steps:
Comment on lines +33 to +34
Copy link

@coderabbitai coderabbitai bot Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify workflow syntax after the fix
# (run if actionlint is available in your environment)
actionlint -oneline .github/workflows/pull_request.yml

Repository: datacite/bracco

Length of output: 215

Remove invalid empty env: block that breaks workflow parsing.

Line 33 declares env: without providing any mapping values. This causes a YAML syntax error that prevents the workflow from running.

Fix 
-    env:
     steps:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
env:
steps:
steps:
🧰 Tools
🪛 actionlint (1.7.11)

[error] 33-33: expecting a single ${{...}} expression or mapping value for "env" section, but found plain text node

(syntax-check)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/pull_request.yml around lines 33 - 34, The workflow
contains an invalid empty env: mapping that breaks YAML parsing; remove the
empty env: declaration (or replace it with a valid mapping) so the workflow
top-level sequence starting at steps: parses correctly — locate the lone env:
entry near the steps: key and delete that empty env: line or populate it with
proper key: value pairs if environment variables are intended.

- name: Checkout
uses: actions/checkout@v4

- name: Extract variables
shell: bash
run: |
echo "BRANCH=$(echo ${GITHUB_REF#refs/heads/} | sed 's/\//_/g')" >> $GITHUB_OUTPUT
echo "GIT_SHA=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
echo "GIT_SHA_SHORT=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
id: extract_variables

- name: Vercel deploy staging
uses: amondnet/vercel-action@v25.1.1
Copy link

@coderabbitai coderabbitai bot Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Resolve the exact commit behind v25.1.1 (read-only)
git ls-remote https://github.com/amondnet/vercel-action refs/tags/v25.1.1 refs/tags/v25.1.1^{}

Repository: datacite/bracco

Length of output: 117

🏁 Script executed:

cat -n .github/workflows/pull_request.yml | sed -n '45,50p'

Repository: datacite/bracco

Length of output: 294

Pin GitHub Action to commit SHA.

Line 47 uses a mutable tag (@v25.1.1). For supply-chain safety, pin to the exact commit SHA instead.

Replace with:

uses: amondnet/vercel-action@225d234cfe5340ca1f9a6cd158338126b5b6845f
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/pull_request.yml at line 47, Change the mutable action
reference "uses: amondnet/vercel-action@v25.1.1" to a pinned commit SHA; locate
the line containing uses: amondnet/vercel-action@v25.1.1 and replace the tag
with the exact commit SHA (e.g.,
amondnet/vercel-action@225d234cfe5340ca1f9a6cd158338126b5b6845f) so the workflow
uses an immutable, audit-able revision.

with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.ORG_ID}}
vercel-project-id: ${{ secrets.PROJECT_ID}}
vercel-args: ${{ vars.VERCEL_NOCACHE == 'true' && '--force' || '' }} --build-env HANDLE_SERVER=${{vars.HANDLE_SERVER}}
scope: ${{ secrets.TEAM_ID}}
vercel-project-name: 'bracco'
Loading