Skip to content

Conversation

@m-abulazm
Copy link
Contributor

@m-abulazm m-abulazm commented Nov 13, 2025

Changes

What does this PR do?

Relevant implementation details

  • Support username and password in spark options instead of jdbc url
  • This makes sure non-url compliant chars in the password aresupported

@m-abulazm m-abulazm self-assigned this Nov 13, 2025
@m-abulazm m-abulazm requested a review from a team as a code owner November 13, 2025 15:23
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.25%. Comparing base (39c1c81) to head (a4ee471).

Files with missing lines Patch % Lines
...ricks/labs/lakebridge/reconcile/connectors/tsql.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   65.23%   65.25%   +0.01%     
==========================================
  Files         100      100              
  Lines        8504     8508       +4     
  Branches      875      875              
==========================================
+ Hits         5548     5552       +4     
  Misses       2769     2769              
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

✅ 51/51 passed, 11 flaky, 4m25s total

Flaky tests:

  • 🤪 test_validate_successful_schema_check (197ms)
  • 🤪 test_validate_invalid_schema_check (1ms)
  • 🤪 test_validate_non_empty_tables (7ms)
  • 🤪 test_validate_mixed_checks (202ms)
  • 🤪 test_validate_invalid_schema_path (1ms)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (23.971s)
  • 🤪 test_transpiles_informatica_to_sparksql (24.39s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (23.772s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (27.194s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (4.123s)
  • 🤪 test_transpile_teradata_sql (7.534s)

Running from acceptance #2961

@m-abulazm m-abulazm enabled auto-merge November 19, 2025 10:04
@asnare asnare changed the title Handle jdbc passwords containing special chars Handle JDBC passwords containing special chars Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants