Fix ValueError when selecting "Enter a different URL" in configure - #104
Merged
Conversation
The workspace picker assumed `questionary.select(...).ask()` returns either a (host, profile) tuple or None, but in some questionary versions selecting the "Enter a different URL" option returns the title string instead, causing `too many values to unpack` on the tuple destructure. Guard the unpack with `isinstance(choice, tuple)` so any non-tuple return (None or a stray string) falls through to the manual URL prompt. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AarushiShah-db
previously approved these changes
May 27, 2026
AarushiShah-db
approved these changes
May 27, 2026
anthonyivn2
pushed a commit
to anthonyivn2/ucode
that referenced
this pull request
May 28, 2026
Resolves tests/test_ui.py — keeps both the layout-coverage tests added on this branch and the return-type-defensiveness tests added on main in PR databricks#104, since they exercise complementary aspects of prompt_for_workspace. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace picker assumed
questionary.select(...).ask()returns either a (host, profile) tuple or None, but in some questionary versions selecting the "Enter a different URL" option returns the title string instead, causingtoo many values to unpackon the tuple destructure. Guard the unpack withisinstance(choice, tuple)so any non-tuple return (None or a stray string) falls through to the manual URL prompt.Fix issue #103