Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#186 Deploy pipeline fails with "staging: no such target. Available t… #187

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

ThomasHenckel
Copy link
Contributor

…argets:

Setting the catalog name in databricks.yml

Updated bundle and pipeline yml files to use the catalog variable in databricks.yml

…vailable targets:

Setting the catalog name in databricks.yml

Updated bundle and pipeline yml files to use the catalog variable in databricks.yml
@arpitjasa-db
Copy link
Collaborator

@ThomasHenckel thanks so much for creating this PR! I ran the tests and they seem to be failing, would you mind taking a look and resolving where you can? Happy to help re-run on future commits

…eric_underscore` .}}/databricks.yml.tmpl

Co-authored-by: Arpit Jasapara <[email protected]>
@ThomasHenckel
Copy link
Contributor Author

@ThomasHenckel thanks so much for creating this PR! I ran the tests and they seem to be failing, would you mind taking a look and resolving where you can? Happy to help re-run on future commits

Hi @arpitjasa-db

Unfortunately I have not setup local to run the large unit tests, when I look at the error it is failing at
"Comparing the output of SGDRegressor.predict revealed that fitting with sample_weight is not equivalent to fitting with removed or repeated data points."
The error is also pressent in the other PR #586

@arpitjasa-db arpitjasa-db merged commit 72e9d5c into databricks:main Jan 2, 2025
1 check failed
@arpitjasa-db
Copy link
Collaborator

@ThomasHenckel I fixed the tests in another PR, though it seems the changes weren't being picked up here. Fixed and merged the PR, thanks for making the contribution!

github-merge-queue bot pushed a commit to databricks/cli that referenced this pull request Jan 2, 2025
## Changes
databricks/mlops-stacks#187 broke mlops-stacks
deployments for non-UC projects. Snoozing the test until upstream is
fixed.

## Tests
The test is skipped on my local machine. CI run will verify it's also
skipped on Github Actions runners.
github-merge-queue bot pushed a commit to databricks/cli that referenced this pull request Jan 3, 2025
## Changes
This test was broken due to upstream change:
databricks/mlops-stacks#187

Fixed in upstream change:
databricks/mlops-stacks#188

## Tests
Test passes now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy pipeline fails with "staging: no such target. Available targets: ..."
2 participants