[Internal] Delete examples/mocking module #1126
Open
+0
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
parthban-db
commented
Jan 17, 2025
| w, err := databricks.NewWorkspaceClient() | ||
| require.NoError(t, err) | ||
|
|
||
| w.Dbfs.WithImpl(mockDbfs) |
There was a problem hiding this comment.
@renaudhartert-db What do you say? Should we delete this module or find a way to support it? Random fact: this mocker is too old that it even uses the Dbfs package, which does not even exist anymore :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR deletes the
examples/mockingdirectory as it is no longer maintained. This mocker example is built on the assumption that everyservicehasWithImpl()that is used to set the stubs for everyservice. But this is no longer the case. This mocker is not even able to compile.How is this tested?
N/A