Add MLflow tracing for langchain and openai implementations of VectorSearchRetrieverTool #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annzhang-db
reviewed
Jan 15, 2025
| vector_search_tool._run("Databricks Agent Framework") | ||
| trace = mlflow.get_last_active_trace() | ||
| spans = trace.search_spans(name=tool_name or index_name, span_type=SpanType.RETRIEVER) | ||
| assert len(spans) == 1 |
There was a problem hiding this comment.
Could we validate that the span logs the correct/expected input and output?
| ) | ||
| trace = mlflow.get_last_active_trace() | ||
| spans = trace.search_spans(name=tool_name or index_name, span_type=SpanType.RETRIEVER) | ||
| assert len(spans) == 1 |
There was a problem hiding this comment.
Could we also validate input/output here?
There was a problem hiding this comment.
I'll leave this as is for now. Discussed offline, but as it stands the current span does not have the correct input/output until this PR merges. I will wait to update the unit test.
annzhang-db
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tracing to the VectorSearchRetrieverTool across the Langchain and Openai implementations. In order to name the trace correctly I've implemented a reusable decorator factory:
Our tools are named based on the user input tool_name otherwise it defaults to the index name.
Tested in UI and it displays the retriever trace correctly:
