Non-DLT CDC/CDF Upgrade - #14
Open
alexvanadio-databricks wants to merge 12 commits into
Open
Conversation
Contributor
Author
|
I spoke to @QuentinAmbard about this PR yesterday. We're going to move forward with testing these changes, but revert the new gold use case due to complexity. This more advanced gold use case will be added to a new notebook, and referenced with a link in the current one. I will create a separate PR for that work. |
Collaborator
|
hi @alexvanadio-databricks ! FYI I cherry picked the commit - but not everything is merged yet (not the agg) - I need to review that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for Issue #13 .
@QuentinAmbard and team, if it helps, you can interact with the notebooks here.
The one thing I'm not confident about is the budle_config.py. I added a cluster section but I'm not sure how to actually test it with dbdemos.
Things I did not do:
Other notes:
maininto my feature branch, but it had a lot more changes than the bugfix. There shouldn't be any merge conflicts with the cherry-pick approach. You can ignore those changes in the diff.