Feature: Abstract Term#1284
Merged
drmingdrmer merged 1 commit intodatabendlabs:mainfrom Dec 26, 2024
Merged
Conversation
SteveLauC
previously approved these changes
Dec 26, 2024
Collaborator
SteveLauC
left a comment
SteveLauC
left a comment
There was a problem hiding this comment.
Looks good:)
Reviewed 14 of 16 files at r1, all commit messages.
Reviewable status: 14 of 16 files reviewed, all discussions resolved (waiting on @schreter)
SteveLauC
reviewed
Dec 26, 2024
| /// such as old leaders. It must be totally ordered and monotonically increasing. | ||
| /// | ||
| /// Common implementations are provided for standard integer types like `u64`, `i64` etc. | ||
| pub trait RaftTerm |
Collaborator
There was a problem hiding this comment.
Module vote is private, so this trait is private as well, this is the reason why the lint CI failed
Line 49 in 93a5585
lichuang
approved these changes
Dec 26, 2024
Add associated type `Term: RaftTerm` to `RaftTypeConfig` so that application can customize the data type for Raft `term`. By default `Term` is `u64` and user application does not need to modify to upgrade. - Part of databendlabs#1278
drmingdrmer
force-pushed
the
175-term
branch
from
33ef13d to
004e3f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Feature: Abstract Term
Add associated type
Term: RaftTermtoRaftTypeConfigso thatapplication can customize the data type for Raft
term.By default
Termisu64and user application does not need to modifyto upgrade.
This change is