Skip to content

Conversation

@forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Nov 8, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Change FunctionData to an association type
Separate SerializeInfo from FunctionData
T::Column to ColumnView<T>
Simplified string_agg implementation

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@forsaken628 forsaken628 changed the title refactor(aggr_func): string agg refactor(aggr_func): aggr_func Nov 8, 2025
@forsaken628 forsaken628 changed the title refactor(aggr_func): aggr_func refactor(query): aggr_func Nov 8, 2025
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 8, 2025
@forsaken628 forsaken628 changed the title refactor(query): aggr_func refactor(query): optimized UnaryState design and simplified string_agg implementation Nov 10, 2025
@forsaken628 forsaken628 changed the title refactor(query): optimized UnaryState design and simplified string_agg implementation refactor(query): optimized UnaryState design and simplified string_agg implementation Nov 10, 2025
@forsaken628 forsaken628 marked this pull request as ready for review November 10, 2025 07:50
@forsaken628 forsaken628 merged commit b02cc59 into databendlabs:main Nov 10, 2025
206 of 214 checks passed
@forsaken628 forsaken628 deleted the string_agg branch November 10, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants