chore: resolve post-merge compilation failure after KvApi refactoring #18761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge of PR databendlabs#18751 and databendlabs#18759 introduced a semantic conflict where vacuum tests were still importing the old KVApi trait instead of the new KvApiExt trait. This caused compilation failures despite no git merge conflicts being detected.
github-actions
bot
added
the
pr-refactor
dantengsky
changed the title
github-actions
bot
added
the
pr-chore
dantengsky
removed
the
pr-refactor
This comment was marked as outdated.
This comment was marked as outdated.
- Return approximate count of removed metadata keys from gc_drop_tables - Add extra logging throughout GC process for better observability - Update catalog interface to support metadata removal tracking - Note: DeleteByPrefix operations count as 1 but may remove multiple keys (currenyly not used in meta GC)
dantengsky
force-pushed
the
chore-resolve-merge-conflict
branch
from
daa8423 to
e71db77
Compare
dantengsky
added
ci-cloud
Docker Image for PR
|
SkyFan2002
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Fix:
The merge of PR #18751 and #18759 introduced a semantic conflict where vacuum tests were still importing the old KVApi trait instead of the new KvApiExt trait. This caused compilation failures despite no git merge conflicts being detected.
Chore: add logging for meta garbage collection operations
Tests
Type of change
This change is