Skip to content

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Sep 19, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

improve the readability of aggregate function hash table

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 19, 2025
@forsaken628
Copy link
Collaborator Author

Abandon https://arxiv.org/html/2501.02305v2, linear probing is inherently low-cost, and the performance gains from complex algorithms do not cover the algorithm's self-generated overheads

@forsaken628 forsaken628 marked this pull request as ready for review September 19, 2025 08:43
@sundy-li sundy-li self-requested a review September 22, 2025 12:20
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forsaken628 forsaken628 merged commit b33e779 into databendlabs:main Sep 23, 2025
168 of 170 checks passed
@forsaken628 forsaken628 deleted the hashtable branch September 23, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants