refactor(meta): replace manual struct instantiation with constructor methods #18393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods Replace manual LogEntry struct instantiation with LogEntry::new(cmd) for cases where time_ms is None, and introduce LogEntry::new_with_time(cmd, time_ms) for cases that need to preserve existing timestamps.
…methods Replace manual struct instantiation with constructor methods across meta types to improve code consistency and maintainability following the LogEntry pattern: - UpsertKV: Use ::new(), ::update(), ::delete() instead of manual instantiation - WatchRequest: Use ::new() with ::with_filter(), ::with_initial_flush() builders - RaftRequest: Use GrpcHelper::encode_raft_request() for consistent serialization - TxnPutRequest: Add ::new() constructor for (key, value, prev_value, expire_at, ttl_ms) - TxnGetRequest: Add ::new() constructor for (key) - TxnDeleteRequest: Add ::new() constructor for (key, prev_value, match_seq) This provides better type safety, readability, and ensures field changes only require updating constructor methods rather than scattered manual instantiations.
github-actions
bot
added
the
pr-refactor
…odule access - Remove unused MatchSeq and Operation imports from util.rs - Fix grpc_helper module access by using re-exported GrpcHelper - Ensure all constructor method refactoring passes clippy lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(meta): replace manual struct instantiation with constructor methods
Replace manual struct instantiation with constructor methods across meta types
to improve code consistency and maintainability following the LogEntry pattern:
This provides better type safety, readability, and ensures field changes only
require updating constructor methods rather than scattered manual instantiations.
refactor(meta): replace manual LogEntry construction with constructor methods
Replace manual LogEntry struct instantiation with LogEntry::new(cmd) for cases
where time_ms is None, and introduce LogEntry::new_with_time(cmd, time_ms) for
cases that need to preserve existing timestamps.
Tests
Type of change
Related Issues
This change is