CARDS-2631: Automatically disable downtime banner once downtime period ends #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veronikaslc
force-pushed
the
CARDS-2631
branch
from
25a9e58 to
370854b
Compare
veronikaslc
added
Test me!
marta-
reviewed
Feb 5, 2025
|
|
||
| // Check if the downtime period ended | ||
| if (new Date() > date) { | ||
| setPeriodEnded(true); |
There was a problem hiding this comment.
This is ok, but we could have just set enabled to false, we don't really need a new state.
There was a problem hiding this comment.
Fixed in d91e2b6, PR got even shorter
…d ends Code optimisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.