Skip to content

Commit

Permalink
Strict xfails on CI, remove missing __dataframe__ xfails
Browse files Browse the repository at this point in the history
  • Loading branch information
honno committed Sep 29, 2022
1 parent b6f5653 commit eabd82c
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ def pytest_configure(config):


ci_xfail_ids = [
# vaex's and cudf's interchange dataframe doesn't have __dataframe__()
# See https://github.com/data-apis/dataframe-api/issues/80
"test_dataframe_object.py::test_dunder_dataframe[vaex]",
"test_signatures.py::test_dataframe_method[vaex-__dataframe__]",
"test_dataframe_object.py::test_dunder_dataframe[cudf]",
"test_signatures.py::test_dataframe_method[cudf-__dataframe__]",
# https://github.com/vaexio/vaex/pull/2150
"tests/test_signatures.py::test_column_method[vaex-size]",
# https://github.com/rapidsai/cudf/issues/11320
Expand Down Expand Up @@ -91,7 +85,7 @@ def pytest_collection_modifyitems(config, items):
if config.getoption("--ci"):
for item in items:
if any(id_ in item.nodeid for id_ in ci_xfail_ids):
item.add_marker(pytest.mark.xfail())
item.add_marker(pytest.mark.xfail(strict=True))
elif any(id_ in item.nodeid for id_ in ci_skip_ids):
item.add_marker(pytest.mark.skip("flaky"))
elif r_cudf_roundtrip.search(item.nodeid):
Expand Down

0 comments on commit eabd82c

Please sign in to comment.